Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set default value of config.supportedScanTypes #521

Merged
merged 1 commit into from
Oct 24, 2022
Merged

fix: set default value of config.supportedScanTypes #521

merged 1 commit into from
Oct 24, 2022

Conversation

rlueder
Copy link
Contributor

@rlueder rlueder commented Aug 9, 2022 •
edited
Loading

@mebjas

This solves the issue reported on #494 where config.supportedScanTypes is not set to a default value like other config properties.

@all-contributors please add @rlueder for this new feature or tests

@rlueder rlueder mentioned this pull request Aug 9, 2022
Closed
jerodfritz
jerodfritz approved these changes Aug 31, 2022
View reviewed changes
Copy link

@jerodfritz jerodfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the error for me.

ROBERT-MCDOWELL
ROBERT-MCDOWELL reviewed Aug 31, 2022
View reviewed changes
Copy link

@ROBERT-MCDOWELL ROBERT-MCDOWELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mebjas
mebjas approved these changes Oct 24, 2022
View reviewed changes
Copy link
Owner

@mebjas mebjas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the CL

@mebjas mebjas merged commit bf829fa into mebjas:master Oct 24, 2022
@mebjas mebjas mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ROBERT-MCDOWELL ROBERT-MCDOWELL ROBERT-MCDOWELL left review comments

@mebjas mebjas mebjas approved these changes

@jerodfritz jerodfritz jerodfritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlueder @jerodfritz @ROBERT-MCDOWELL @mebjas